Skip to content

Conversation

@smaddock
Copy link
Contributor

@smaddock smaddock commented Jul 8, 2025

Following conversation here: #402 (comment)

@smaddock smaddock requested a review from a team as a code owner July 8, 2025 23:58
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.46%. Comparing base (8724759) to head (f6ca651).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #403      +/-   ##
============================================
- Coverage     82.50%   81.46%   -1.05%     
+ Complexity     2009     1667     -342     
============================================
  Files           144      120      -24     
  Lines          8329     6953    -1376     
============================================
- Hits           6872     5664    -1208     
+ Misses         1457     1289     -168     
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.42% <ø> (ø)
Instrumentation/AwsSdk 81.13% <ø> (ø)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.55% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/Doctrine 92.92% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 75.58% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 69.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (ø)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (ø)
Instrumentation/Psr3 67.01% <ø> (ø)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.45% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (ø)
Instrumentation/Symfony 84.88% <ø> (+0.14%) ⬆️
Logs/Monolog 100.00% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony ?
Utils/Test 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Aws/src/AwsSdkInstrumentation.php 95.55% <ø> (ø)
src/Aws/src/Ec2/Detector.php 90.90% <ø> (ø)
src/Aws/src/Ecs/DataProvider.php 0.00% <ø> (ø)
src/Aws/src/Ecs/Detector.php 92.38% <ø> (ø)
src/Aws/src/Eks/DataProvider.php 100.00% <ø> (ø)
src/Aws/src/Eks/Detector.php 84.00% <ø> (ø)
src/Aws/src/Lambda/Detector.php 100.00% <ø> (ø)
src/Aws/src/Xray/IdGenerator.php 100.00% <ø> (ø)
src/Aws/src/Xray/Propagator.php 100.00% <ø> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8724759...f6ca651. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

smaddock added a commit to smaddock/opentelemetry-php-contrib that referenced this pull request Jul 9, 2025
Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add /examples to .gitattributes export-ignore list? 👍

@smaddock
Copy link
Contributor Author

smaddock commented Jul 9, 2025

Please could you add /examples to .gitattributes export-ignore list? 👍

@ChrisLightfootWild should all examples be export-ignored? E.g., /src/**/examples

Edit: I see the package has its own .gitattributes, which is likely what you were referring to; my question applies to the monorepo .gitattributes.

@ChrisLightfootWild
Copy link
Contributor

Please could you add /examples to .gitattributes export-ignore list? 👍

@ChrisLightfootWild should all examples be export-ignored? E.g., /src/**/examples

Edit: I see the package has its own .gitattributes, which is likely what you were referring to; my question applies to the monorepo .gitattributes.

You got it 👍

I think we can ignore the root level one as that package is abandoned:
https://packagist.org/packages/open-telemetry/opentelemetry-php-contrib

@brettmc brettmc merged commit 30ed261 into open-telemetry:main Jul 9, 2025
144 of 153 checks passed
brettmc pushed a commit that referenced this pull request Jul 22, 2025
* alphabetize .gitsplit.yml

* add missing sub-package refs to composer.json

* add missing composer.json to dependabot (and reorder PSRs)

* add missing projects to php.yml

* Revert "add missing projects to php.yml"

This reverts commit 1c3eef5.

* namespace updates from #403 and #404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants